Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OD-174 [Feature] Now users will see the default template at once when they put a new form to the app. #320

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

YaroslavOvdii
Copy link
Contributor

@YaroslavOvdii YaroslavOvdii commented Jul 27, 2020

@sofiiakvasnevska

Issue

https://github.com/Fliplet/fliplet-studio/issues/6740
https://weboo.atlassian.net/browse/OD-174

Description

Now users will see the default template at once when they put a new form to the app.

Screenshots/screencasts

https://share.getcloudapp.com/bLuR1GDY

Backward compatibility

This change is fully backward compatible.

Reviewers

@upplabs-alex-levchenko

@tonytlwu
Copy link
Contributor

@sofiiakvasnevska @squallstar We should confirm what's going to happen with organisation form templates first before reviewing this.

@squallstar
Copy link
Contributor

@tonytlwu agreed, I see that you already went forward on asking for confirmation to CS and Ian in the ticket so I'll wait until they come back to us before reviewing this.

@sofiiakvasnevska sofiiakvasnevska changed the title [Feature] Now users will see the default template at once when they put a new form to the app. OD-174 [Feature] Now users will see the default template at once when they put a new form to the app. Oct 7, 2020
@sofiiakvasnevska
Copy link
Contributor

@squallstar Ian has **confirmed** could you please review the PR

@squallstar
Copy link
Contributor

squallstar commented Oct 7, 2020

@sofiiakvasnevska @YaroslavOvdii what about organizations that have already defined form templates and are actively using them? Will the current change keep the existing behaviour and display the template selection?

cc @tonytlwu

Note that this is outlined in the original ticket as a requirement in the comments.

@tonytlwu
Copy link
Contributor

tonytlwu commented Oct 8, 2020

@sofiiakvasnevska The confirmation suggests that if organisation form templates are available, users should have the ability to choose an organisation form templates first.

This PR shows the template selection UI being removed entirely, in contrary to the above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants